These forums have been archived and are now read-only.

The new forums are live and can be found at https://forums.eveonline.com/

EVE Technology Lab

 
  • Topic is locked indefinitely.
 

EVE-O preview - multi-client preview / switcher - v 1.13

First post
Author
CCP FoxFour
C C P
C C P Alliance
#121 - 2014-12-01 10:23:23 UTC
Makari Aeron wrote:
Looks good FoxFour. I compiled and am now using your branch. Tried to make a trackbar which would adjust the preview based on a percentage of the client window but decided that simply resizing it with "show preview frames" checked is far simpler.

I'm going to see if I can pin down this crashing issue I keep getting when I close the last client in the list. Every time it crashes I am not debugging. Oh well. I'll find it eventually.


That would indeed be nice. I just edit the config file to get perfect sizes for the preview windows, client windows, and their positions

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

Mistress Somni
The Dirty Rotten Scoundrels
HYDRA RELOADED
#122 - 2014-12-01 11:12:02 UTC
CCP FoxFour wrote:
Not sure if the OP is still around, but I submitted a pull request over lunch for a new feature. Will see if he responds. :)

StinkRay doesn't log on much any more, but I'm sure he would be glad to see that people are still using this tool.
Makari Aeron
Imperial Shipment
Amarr Empire
#123 - 2014-12-01 12:19:58 UTC
Michelle Monteleone wrote:
Hey they have a great program that does this already and it's profoundly better at it. You may have heard of it. It's called ISBOXER.


Except this is free, open source (I can fix the bugs I find), and doesn't possess the soon-to-be-banned automation features that I might accidentally click on if I'm not paying attention. All-in-all, I'll take a slightly buggy open source program over a subscription based program any day.

I'll see if I can pin down that crashing bug as well as why the overlay text doesn't disappear when a preview is removed (aka a client is closed). At least, that's my goal for this week.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

CCP FoxFour
C C P
C C P Alliance
#124 - 2014-12-01 13:18:01 UTC
Makari Aeron wrote:
why the overlay text doesn't disappear when a preview is removed (aka a client is closed). At least, that's my goal for this week.


Just ran into that. Made me sad. :(

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

Makari Aeron
Imperial Shipment
Amarr Empire
#125 - 2014-12-01 13:30:26 UTC
CCP FoxFour wrote:
Makari Aeron wrote:
why the overlay text doesn't disappear when a preview is removed (aka a client is closed). At least, that's my goal for this week.


Just ran into that. Made me sad. :(


Yeah. And if you open up another client and put the preview in the same location (ie: same account, different character or what have you), the text is still floating there. My guess is that the overlay text isn't disposed/removed when that preview window is closed. I need to test to see if it's just the borderless preview (I think he calls it "flat"?) or if it's the windowed preview as well. I use the borderless as I tend to accidentally click and drag the windowed previews around. Once I'm done with my EVE payment plan (aka "work") I'll see if I can work on the overlay thing. That shouldn't be too hard to pin down as it's happens every time.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

CCP FoxFour
C C P
C C P Alliance
#126 - 2014-12-01 13:41:32 UTC
Makari Aeron wrote:
CCP FoxFour wrote:
Makari Aeron wrote:
why the overlay text doesn't disappear when a preview is removed (aka a client is closed). At least, that's my goal for this week.


Just ran into that. Made me sad. :(


Yeah. And if you open up another client and put the preview in the same location (ie: same account, different character or what have you), the text is still floating there. My guess is that the overlay text isn't disposed/removed when that preview window is closed. I need to test to see if it's just the borderless preview (I think he calls it "flat"?) or if it's the windowed preview as well. I use the borderless as I tend to accidentally click and drag the windowed previews around. Once I'm done with my EVE payment plan (aka "work") I'll see if I can work on the overlay thing. That shouldn't be too hard to pin down as it's happens every time.


Would explain why I don't usually see it. I keep the borders on.

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

Makari Aeron
Imperial Shipment
Amarr Empire
#127 - 2014-12-01 15:16:41 UTC  |  Edited by: Makari Aeron
FoxFour, if you could try something for me since I am at work it would be appreciated. If not, I'll test the fix when i get home in roughly 6 hours. I may have found the solution persistent overlay bug. My guess is that it was assumed that when "previews[processHandle].Close();" was called, that the preview's overlay would close as well. That is not the case and so "spawn_and_kill_previews()" needs to close the overlay as well as the preview.

In "PreviewHandler.cs" on line 196 add:
previews[processHandle].overlay.Close();




EDIT: though anther way to fix the persistent overlay bug would be an onFormClosing/onFormClose event for "preview" to close the overlay. That might work better actually. This would cause a daisychain and would negate any sort of problem with calling one before the other.

"Preview.cs"
Line 263

Closing:

        private void Preview_Load(object sender, EventArgs e)
        {
            this.FormClosing += Preview_FormClosing;
        }

        void Preview_FormClosing(object sender, FormClosingEventArgs e)
        {
            overlay.Close();
        }



Closed:

        private void Preview_Load(object sender, EventArgs e)
        {
            this.FormClosed += Preview_FormClosed;
        }

        void Preview_FormClosed(object sender, FormClosedEventArgs e)
        {
            overlay.Close();
        }

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

Makari Aeron
Imperial Shipment
Amarr Empire
#128 - 2014-12-01 22:06:36 UTC  |  Edited by: Makari Aeron
I'm going to be bad an double post because another edit isn't going to draw attention to those watching this thread.

You can find my branch of the repository here: https://bitbucket.org/MakariAeron/eve-o-preview/src

It incorporates FoxFour's client location tracking and my fix to the persistent overlay text bug. And here you can find a zip of the current binary. Enjoy!

https://bitbucket.org/MakariAeron/eve-o-preview/downloads/eve-o%20preview1.14.zip


@FoxFour: I have sent a pull request to merge my changes (persistent_overlay_text_bugfix) with your feature_track_client_windows

I'm still trying to pin down that crashing bug. I haven't been able to replicate it but I'm sure it'll pop up eventually. Enjoy folks!

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

Takagamu
Core Runners
#129 - 2014-12-02 12:57:19 UTC  |  Edited by: Takagamu
Heya,

there seems to be a problem with the main program window losing focus in some interval. It makes it almost impossible to enter values in the textfields.

Must be something in PreviewHandler.spawn_and_kill_previews ... didn't have time to check it in detail yet, but commenting this function out stops this behaviour.

Using Windows7 64bit, one to three clients running and used Makari Aeron's repository (downloaded 10min ago)
Makari Aeron
Imperial Shipment
Amarr Empire
#130 - 2014-12-02 13:02:08 UTC
It was like that in the 1.13 version of the program as well. I don't use the input boxes, instead I scale the previews by checking the "syncronize resize" box and resizing one of the preview windows. Then I go to borderless mode. It has to do with how he implemented the timers. That's on my list to figure out how to fix, if I can.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

CCP FoxFour
C C P
C C P Alliance
#131 - 2014-12-02 13:04:07 UTC
Makari Aeron wrote:
It was like that in the 1.13 version of the program as well. I don't use the input boxes, instead I scale the previews by checking the "syncronize resize" box and resizing one of the preview windows. Then I go to borderless mode. It has to do with how he implemented the timers. That's on my list to figure out how to fix, if I can.


It seemed like that was going to require a bit of a rewrite to fix properly.

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

CCP FoxFour
C C P
C C P Alliance
#132 - 2014-12-02 13:05:52 UTC
Makari Aeron wrote:
I'm going to be bad an double post because another edit isn't going to draw attention to those watching this thread.

You can find my branch of the repository here: https://bitbucket.org/MakariAeron/eve-o-preview/src

It incorporates FoxFour's client location tracking and my fix to the persistent overlay text bug. And here you can find a zip of the current binary. Enjoy!

https://bitbucket.org/MakariAeron/eve-o-preview/downloads/EVE-O%20Preview%201.14.zip


@FoxFour: I have sent a pull request to merge my changes (persistent_overlay_text_bugfix) with your feature_track_client_windows

I'm still trying to pin down that crashing bug. I haven't been able to replicate it but I'm sure it'll pop up eventually. Enjoy folks!


I saw that but it contained a few other bits that made it a bit of a mess. That or I don't understand Bitbucket and Mercurial... which I really don't so that maybe the case. >.<

Either way, I commented on it. :)

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

Makari Aeron
Imperial Shipment
Amarr Empire
#133 - 2014-12-02 13:12:27 UTC  |  Edited by: Makari Aeron
CCP FoxFour wrote:
Makari Aeron wrote:
It was like that in the 1.13 version of the program as well. I don't use the input boxes, instead I scale the previews by checking the "syncronize resize" box and resizing one of the preview windows. Then I go to borderless mode. It has to do with how he implemented the timers. That's on my list to figure out how to fix, if I can.


It seemed like that was going to require a bit of a rewrite to fix properly.


That's what I thought too. I'd rather avoid that for now >_>;

A quick fix might be to open a new form so you can put in the H/W values. I'm trying to avoid rewriting the timers....I hate timers.

CCP FoxFour wrote:
Makari Aeron wrote:
I'm going to be bad an double post because another edit isn't going to draw attention to those watching this thread.

You can find my branch of the repository here: https://bitbucket.org/MakariAeron/eve-o-preview/src

It incorporates FoxFour's client location tracking and my fix to the persistent overlay text bug. And here you can find a zip of the current binary. Enjoy!

https://bitbucket.org/MakariAeron/eve-o-preview/downloads/EVE-O%20Preview%201.14.zip


@FoxFour: I have sent a pull request to merge my changes (persistent_overlay_text_bugfix) with your feature_track_client_windows

I'm still trying to pin down that crashing bug. I haven't been able to replicate it but I'm sure it'll pop up eventually. Enjoy folks!


I saw that but it contained a few other bits that made it a bit of a mess. That or I don't understand Bitbucket and Mercurial... which I really don't so that maybe the case. >.<

Either way, I commented on it. :)



Thanks, I saw. I removed the pull request for now. I don't understand Bitbucket and Mercurial either LOL. I'll do some research today and figure out how that stuff works.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

l0rd carlos
the king asked me to guard the mountain
#134 - 2014-12-02 13:29:26 UTC
Import it to github :>

Youtube Channel about Micro and Small scale PvP with commentary: Fleet Commentary by l0rd carlos

Takagamu
Core Runners
#135 - 2014-12-02 13:33:22 UTC
Makari Aeron wrote:
I'm still trying to pin down that crashing bug. I haven't been able to replicate it but I'm sure it'll pop up eventually. Enjoy folks!


Just stopped testing and closed an Eve window while the previewer was still running.

Got an exception at Preview.cs Line 196, Value out of bounds ("Der Wert liegt außerhalb des erwarteten Bereichs.")

at PreviewToy.DwmApi.DwmUpdateThumbnailProperties(IntPtr hThumbnail, DWM_THUMBNAIL_PROPERTIES props)

I think it tries to interact with the closed window, so I added this call to Win32api.cs

        [DllImport("user32.dll")]
        [return: MarshalAs(UnmanagedType.Bool)]
        public static extern bool IsWindow(IntPtr hWnd);


and this one to Preview.cs function RefreshPreview Line 189

public void RefreshPreview()
        {
          if (has_been_set_up)
            {
              if (!DwmApi.IsWindow(this.sourceWindow)) {
                has_been_set_up = false;
                return;
              }


Did the trick for me, but I'm not as familiar with the sourcecode as you two AND I don't use bitbucket ... so ... yeah. Hope that helps :)
Makari Aeron
Imperial Shipment
Amarr Empire
#136 - 2014-12-02 13:37:07 UTC
Thanks! I'll do that when I get home from work tonight.

And yeah, I may end up switching it to github. I don't know yet.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

CCP FoxFour
C C P
C C P Alliance
#137 - 2014-12-02 13:55:28 UTC
Makari Aeron wrote:
Thanks! I'll do that when I get home from work tonight.

And yeah, I may end up switching it to github. I don't know yet.


/me would not complain

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

CCP FoxFour
C C P
C C P Alliance
#138 - 2014-12-02 14:12:24 UTC
http://hg-git.github.io/

Guess it should be as simple as install that and


hg bookmark -r default master # make a bookmark of master for default, so a ref gets created
hg push git+ssh://git@github.com/schacon/hg-git.git

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.

Makari Aeron
Imperial Shipment
Amarr Empire
#139 - 2014-12-02 14:35:15 UTC
Yeah...I was just going to download the source and upload it to hithub and then branch it for your fix and then for mine >_>

I'll look into that converter.

CCP RedDawn: Ugly people are just playing life on HARD mode. Personally, I'm playing on an INFERNO difficulty.

CCP Goliath: I often believe that the best way to get something done is to shout at the person trying to help you. http://goo.gl/PKGDP

CCP FoxFour
C C P
C C P Alliance
#140 - 2014-12-02 14:48:43 UTC
Makari Aeron wrote:
Yeah...I was just going to download the source and upload it to hithub and then branch it for your fix and then for mine >_>

I'll look into that converter.


Nice thing is it keeps the commit history, which while not required, would probably be nice. :)

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.