These forums have been archived and are now read-only.

The new forums are live and can be found at https://forums.eveonline.com/

EVE Technology Lab

 
  • Topic is locked indefinitely.
Previous page12
 

Lets talk implants in the char/CharacterSheet endpoint

First post First post
Author
Previous Topic Next Topic
Valterra Craven
#21 - 2014-10-09 18:29:54 UTC
CCP FoxFour wrote:
Sentient Blade wrote:
If pulling 5 rows from the DB creates a significant problem either from the DB or the code then it would suggest there are much bigger issues at play =\


It's not a performance issue, it's an issue of keeping a clean code base and not having it become a giant mess.


I support doing it right the first time. We don't need to relive the POS code excuses in other systems 5 years down the road.
Dragonaire
Here there be Dragons
#22 - 2014-10-09 20:07:19 UTC
I like the change even if it does mean I'll be having to update Yapeal to account for the new structure. I do have a question on how the lastRespecDate and lastTimedRespec are used. They would seem to be one and the same thing almost but I'm guess they aren't. Maybe a little different naming would help to make their propose clearer. Or at least some clarification on what they mean.

Finds camping stations from the inside much easier. Designer of Yapeal for the Eve API. Check out the Yapeal PHP API Library thread.
Dragonaire
Here there be Dragons
#23 - 2014-10-09 21:22:58 UTC  |  Edited by: Dragonaire
oh one other thing can you make sure all the rowsets are after all of the other elements and not like your example with balance hiding out down in the middle it'll make things much easier for everyone trying to parse it Smile I haven't had a chance to try it on the test server to see if it works that way but if not moved that would make it much harder to work with I think.

Edit: Just tried it on test server and it is out of order in the middle of the rowsets Sad.

Finds camping stations from the inside much easier. Designer of Yapeal for the Eve API. Check out the Yapeal PHP API Library thread.
Steve Ronuken
Fuzzwork Enterprises
Vote Steve Ronuken for CSM
#24 - 2014-10-09 21:35:02 UTC
Dragonaire wrote:
oh one other thing can you make sure all the rowsets are after all of the other elements and not like your example with balance hiding out down in the middle it'll make things much easier for everyone trying to parse it Smile I haven't had a chance to try it on the test server to see if it works that way but if not moved that would make it much harder to work with I think.



Surely if you're treating it as XML, it really doesn't matter where the data is?

You can either iterate through it, dealing with each segment with an appropriate callback, or use xpath to pull the relevant sections?

Woo! CSM XI!

Fuzzwork Enterprises

Twitter: @fuzzysteve on Twitter
Dragonaire
Here there be Dragons
#25 - 2014-10-10 02:40:52 UTC
I validate it with XSD and it tends to care about order things are in plus there a couple other reasons that are particular to Yapeal that make it nicer to be better ordered. I have ways to work around if need be. There's also the not messing with people that have CDO (OCD) factor to consider Blink

Finds camping stations from the inside much easier. Designer of Yapeal for the Eve API. Check out the Yapeal PHP API Library thread.
Slvrsmth
Native Freshfood
Minmatar Republic
#26 - 2014-10-10 07:17:56 UTC
A list of typeIDs seems to be a great general solution.

Breakage could be avoiding by including this new block now, and then announcing a date when old one will be removed. Say, three months? Should be enough for the actively developed applications to get updated, and push the changes to their users. That could also accommodate slow rollouts (ex: mobile applications), because both old and new code paths should be able to work in the 'grace period'.

But really, you want API versioning. Aggressively retiring old versions if you wish for the code base to remain compact, but in the long run it's very much worth it.

Carebearium - find the best solar system for you!
Steve Ronuken
Fuzzwork Enterprises
Vote Steve Ronuken for CSM
#27 - 2014-10-10 09:01:36 UTC
Dragonaire wrote:
I validate it with XSD and it tends to care about order things are in plus there a couple other reasons that are particular to Yapeal that make it nicer to be better ordered. I have ways to work around if need be. There's also the not messing with people that have CDO (OCD) factor to consider Blink



Ahh.

Thanks Smile I was wondering.

Woo! CSM XI!

Fuzzwork Enterprises

Twitter: @fuzzysteve on Twitter
Desmont McCallock
#28 - 2014-10-12 08:17:03 UTC  |  Edited by: Desmont McCallock
I decided today to have a look on the changes made that are live on Sisi and it made me extremely happy to find out that they didn't broke EVEMon \o/ (partially because we have done a good job with the code on our side too). Now lets dive into it and implement the changes so we are ready when it goes live on TQ.
Desmont McCallock
#29 - 2014-10-12 12:12:09 UTC
@CCP FoxFour
I'm not seeing any implant reference in the implants rowset for slots 6-10. The jumpCloneImplants have them though.
CCP FoxFour
C C P
C C P Alliance
#30 - 2014-10-12 12:46:55 UTC
Desmont McCallock wrote:
@CCP FoxFour
I'm not seeing any implant reference in the implants rowset for slots 6-10. The jumpCloneImplants have them though.


Thanks, I actually didn't test those implants. Will take a look on Monday.

@CCP_FoxFour // Technical Designer // Team Tech Co

Third-party developer? Check out the official developers site for dev blogs, resources, and more.
Previous page12