EVE Technology Lab

You can get LP store from test crest

Hi.
I must admit, that your lib is a great work!

But... I'm getting a lot of "Safe handle has been closed" exceptions when using crest.

I'm using only one instance of EveCrest.
When using crest.GetRoot().Query(r=>r.Regions), its like 5 of 6 times, when i get that exception.
On market queries, i get it in about 1% of queries.

My code is:

            var allRegions =
                crest.GetRoot()
                    .Query(r => r.Regions)
                    .Query(r => r.Items)
                    .OrderBy(item => Helpers.GetRegionOrder((int)item.Id));

Stack trace is:

   at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
   at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)
   at System.Security.Cryptography.Utils.HashData(SafeHashHandle hHash, Byte[] data, Int32 cbData, Int32 ibStart, Int32 cbSize)
   at System.Security.Cryptography.SHA1CryptoServiceProvider.HashCore(Byte[] rgb, Int32 ibStart, Int32 cbSize)
   at System.Security.Cryptography.HashAlgorithm.ComputeHash(Byte[] buffer)
   at eZet.EveLib.Core.Cache.EveLibFileCache.getHash(Uri uri)
   at eZet.EveLib.Core.Cache.EveLibFileCache.< StoreAsync >d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at eZet.EveLib.EveCrestModule.RequestHandlers.CachedCrestRequestHandler.< GetAsync >d__53`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at eZet.EveLib.EveCrestModule.EveCrest.< getAsync >d__121`1.MoveNext()

Do you think you can look into it, or give me a hint, what should i do to not get this exception?
Thanks.

Added support for LP stores as requested, and also NpcCorporationCollection and Stations.
https://www.nuget.org/packages/eZet.EveLib.EveCrest/3.4.3

No plans, no. Why, is it causing any problems ?

You can set the amount of concurrent requests you allow through EveCrest.RequestHandler.AuthedMaxConcurrentRequests. And as far as I know 100 req/sec is roughly what is allowed, which is why the default value is what it is.

The library is built from the ground up using the task API and is how it should be used, ideally. There are async versions of all methods. Asynchronicity is not the same as parallelism, but in this case where most of the time is spent waiting for a response, parallelism doesn't make much sense.

With that said, what errors are you getting ?

If you give me some more code examples I'll have a look again. But, if you want better performance, use the async methods, that is, the methods that end with Async. Using these will take care of everything in regards to "parallelism", granted you will probably have to make some changes to your code. I could possibly help if you've got examples.

One would think the latest updates would help with your way of doing it though, as access to the cache is being controlled by locks now.

A small project I've been working on lately to reduce the maintenance efforts required to keep up with crest changes, here's an attempt at a dynamic crest library for .net.

https://www.nuget.org/packages/eZet.EveLib.DynamicCrest

In many ways it's similar to the EveCrest library, at least syntactically, but also very different.

It currently supports GetAsync and PostAsync, Put and Delete are not implemented yet. GetAsync is equal to QueryAsync in EveCrest. The major difference is, all methods return Expando objects, which is a custom implementation of DynamicObject, which support late binding. This means it offers no static or compile time type checking, but also automatically supports every crest resource right out of the gate, and any changes will be reflected immediately.

Sample use:

var crest = new DynamicCrest();
var root = await crest.GetAsync(crest.Host);
var alliance = await (await root.GetAsync(r => r.alliances)).GetAsync(a => a.First(o => o.id == 99000967));

As you can see, it's very similar to how EveCrest is used. It already supports automatic pagination when querying collections, and all the other good stuff. One difference is that the property names are now strictly camelCased, directly mirroring the json response. So what would be r.Alliances in EveCrest is now r.alliances.

Basic support for POST requests are also available:

        public async Task AddWaypoint() {
            var character = await (await (await crest.GetAsync(crest.Host)).GetAsync(r => r.decode)).GetAsync(r => r.character);
            var system = (await(await crest.GetAsync(crest.Host)).GetAsync(r => r.systems)).First();
            or //var system = new Resource(30000142, "http://crest.regner.dev/solarsystems/30000142/");
            var wp = new AutopilotWaypoint(system);
            or //wp.SolarSystem = system;
            await crest.PostAsync(character["waypoints"].href, wp);
        }

If you need access to an endpoint that isn't yet supported in EveCrest, this can be used to access anything made available through crest. To find which properties are available, you can enumerate the Properties property on the Expando object, which provides an IDictionary[string, object] interface to all the properties.

Keep in mind that this is an early preview.
In time I hope to have this replace EveCrest, since the amount of maintenance needed to keep up with CREST changes is a bit much.

Root is the same, unauthorized requests will be denied upon performing the request.

Well, they will only be denied if the request is unauthorized. If you authenticate with the SSO you should be good ? And yeah, you are supposed to go through the root. All I'm saying is the root doesn't change based on authentication, the authorization check is performed upon requesting an endpoint that requires authentication, the root is public.