These forums have been archived and are now read-only.

The new forums are live and can be found at https://forums.eveonline.com/

EVE Technology Lab

 
  • Topic is locked indefinitely.
 

TEA (v1.3.1) - Member Management Mod for SMF 2, TeamSpeak 3 and Jabber

Author
Dark Sequent
IMORTALS
Corpse Disposal Services
#221 - 2014-03-15 21:09:03 UTC  |  Edited by: Dark Sequent
The latest patch has disrupted the API mode for the forums we are running 1.3.1 r4
any suggestions please
Cyerus
University of Caille
Gallente Federation
#222 - 2014-03-16 00:17:30 UTC
Demitrios wrote:
I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it.

By "they" you mean the actual TEA developer I hope? If not, you are an idiot and please stfu, and here is why.

Like some posts before you, its clear that the "old" way of parsing xml TEA is using is error prone, as it can easily be broken by even valid xml documents. A proper way would be to use SimpleXML to parse it (and catch it for invalid XML results), and grab the values from the returned object. Even better would be to use PhealNG, as PhealNG uses SimpleXML internally while also providing checks for cache and valid keys (based on requests).

For the last couple of years we (the 3rd party developers, mainly located on Coldfront IRC channel #eve-dev) have been requesting updates to the EVE API, mainly to remove annoyances and limitations because of outdated code. Where most CCPers made only small changes (some good, some bad), we haven't really had any big updates. True, CAKs came out making it easier for people to share api keys, but in the end no big changes were made to the data itself.

Since the introduction of the CAKs CCP started to monitor API errors even more closely. By that, I mean that if you try to get the characterId with a nonexistants characterName, you'd get an error stating that the 'character doesn't exist'. Errors are logged based on IP. If you get too many errors (like if you try to find all characters in EVE), you'll get temp/perm-banned from the EVE API.

This however did not make sense as you had to query some API endpoints to figure out certain information (like killmails and if the character was part of FW), which would return an error. Killmails in particular was an annoying call, as per character you could only get the killmail list once per hour in total (not dependant on IP). So if zKB would query the killmail endpoint, Battleclinic and others would receive an error. Imagine that happening to the thousands of API requests per hour, and yes you can guess it....*poof*...killboards were banned by CCPs strict policy. PrismX saved the day by removing such bans until a new killmail API was built and released, allowing killmails to be checked by multiple killboards.

Things slowed down after this though. We were hoping for more conversation between CCP and 3rd party developers, but unfortunately the API is only considered a side-project by CCP which has to make way for more important stuff. In short, PrismX doesn't have a lot of time to invest on it.

Luckily, FoxFour was able to save the day. Even though the API is not his project, he was able to introduce small tweaks which we've been waiting for for a long time. Most noticeable is the CREST killmail endpoint allowing players to easily post killmails to killboards in a verified way. But also small changes like adding factionId and factionName to most character-based calls so you don't have to generate any errors anymore to figure out if a character is part of FW. Or the new OwnerId call where you can actually see what the ownerType is you are requesting (figure out if Cyerus might a character, corporation or alliance), effectively making CharacterID obsolete.. (more information can be found here).

And yes, you are correct in saying CCP should fix this small bug, and they certainly will. However, I'd like to point out its not their fault for you not helping to test the new changes. Yes, you, the person who has been using TEA for over 4 years without a problem blaming CCP for every small glitch, while you could've set up a test forum pointing to the updated Sisi API server to see if everything would be working correctly..

After all; CCP FoxFour went far and beyond to make those API changes, I guess a small "thank you" is impossible to say.

ps. Vote Fuzzysteve for CSM, as he's the only CSM candidate whom I've seen contribute in the CCP / 3rd party developer scene.
Shin Chogan
Federal Navy Academy
Gallente Federation
#223 - 2014-03-16 00:31:34 UTC  |  Edited by: Shin Chogan
Cyerus wrote:
Demitrios wrote:
I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it.

By "they" you mean the actual TEA developer I hope? If not, you are an idiot and please stfu, and here is why.




lol ... they put out invalid XML and I should "fix" it ? To be honest I'm not sure why the invalid XML isn't being handled in these guy's versions, still not sure what they are all running, r5 should handle it but r4 wouldn't work well What? My version handled it just fine but it does have some not released code.

edit : I should say I appreciate any and all improvements to the API, and I certainly don't blame any individual, as one of the Dev's said in that twitter link a few posts back the code review should have caught it. Even then people are human and we often see what we expect to see which is why you have code reviews prior to release, trouble is the code reviewer is also human and can miss stuff. Meh ... **** happens but should I go out of my way to recode TEMARS to get round their mistake that should be gone in a few days and should in theory never happen again ?
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#224 - 2014-03-16 10:00:14 UTC  |  Edited by: Demitrios
Cyerus wrote:
Diatribe followed by spam asking people to vote for someone in the CSM election.


1, The version of TEA i use does use simplexml.
2, If you bothered to read the twitter messages that went between me and CCP FoxFour, you would see that while i was annoyed to begin with, he explained what happened, and why the error was allowed to go into a production service without anything being caught in a code review. Which instantly killed any anger I had, as somebody who made the change, was fixing it.
3, I did thank him, mostly due to him fixing the problem within an hour of being made aware of the problem, and partly because we didn't have to wait for weeks for CCP to go through it's usual internal argument of "NOPE! EVERYTHING IS FINE!".
Zenith Gravit
LionGate Enterprises
#225 - 2014-03-16 19:00:01 UTC
I'm not sure if anyone else has run into this, but I just resolved an issue with my mail queue in SMF not processing because the TEA Cron tasks had all been declared twice. Maybe just a fluke, but hopefully this bit of info saves someone else the headache I just had.
Yngwiedis
Yngwie J. Malmsteen's Rising Force
#226 - 2014-03-17 20:02:46 UTC
Hello...

I have version 1.3.1 R2 installed in my forum.
I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible.
I already try 5 times and every time i had to get a forum files backup and upload them again.
Can you help me with that problem please ?

Thank you.
Yveth
Ascendance
Goonswarm Federation
#227 - 2014-03-17 20:35:24 UTC  |  Edited by: Yveth
Yngwiedis wrote:
Hello...

I have version 1.3.1 R2 installed in my forum.
I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible.
I already try 5 times and every time i had to get a forum files backup and upload them again.
Can you help me with that problem please ?

Thank you.


Download the file index.php from your host,
Open it and search: require_once($sourcedir.'/TEA.php');

remove or //require_once($sourcedir.'/TEA.php');
this line and save, upload and refresh.

This should do the trick.

(worked for me)
Yngwiedis
Yngwie J. Malmsteen's Rising Force
#228 - 2014-03-17 21:37:12 UTC  |  Edited by: Yngwiedis
Yveth wrote:
Yngwiedis wrote:
Hello...

I have version 1.3.1 R2 installed in my forum.
I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible.
I already try 5 times and every time i had to get a forum files backup and upload them again.
Can you help me with that problem please ?

Thank you.


Download the file index.php from your host,
Open it and search: require_once($sourcedir.'/TEA.php');

remove or //require_once($sourcedir.'/TEA.php');
this line and save, upload and refresh.

This should do the trick.

(worked for me)


No luck. Still white screen...

EDIT: Nevermind. After several tries i manage to uninstall R2 and install R5.
Everything is fine now.
Thank you.
Tahnil
Gunboat Commando
#229 - 2014-03-18 08:43:48 UTC
How did you manage this? Because I seem to have the same problem.
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#230 - 2014-03-18 19:35:55 UTC
Just playing with the new version, and for some reason, the mod is allowing people to register without putting any api details in, yet the mod is set to require api details for registration.

It doesn't throw up any errors, you just skip the api details and hit register, and an account is made.

Any ideas, Shin?

Thanks,

Demi
Eld83
ZERO T0LERANCE
RAZOR Alliance
#231 - 2014-03-19 12:20:18 UTC
They did not fix that API-Call yet, did they?
Liez Onerbak
Norse'Storm Battle Group
#232 - 2014-03-19 14:44:04 UTC
Eld83 wrote:
They did not fix that API-Call yet, did they?


Doesn't look like it. Not yet.
Shin Chogan
Federal Navy Academy
Gallente Federation
#233 - 2014-03-19 20:26:47 UTC
Demitrios wrote:
Just playing with the new version, and for some reason, the mod is allowing people to register without putting any api details in, yet the mod is set to require api details for registration.

It doesn't throw up any errors, you just skip the api details and hit register, and an account is made.

Any ideas, Shin?

Thanks,

Demi



Yeah ... I'd missed a test case and screwed up ...
https://forums.eveonline.com/default.aspx?g=posts&m=4148939#post4148939 should fix that issue.
Shin Chogan
Federal Navy Academy
Gallente Federation
#234 - 2014-03-19 20:36:04 UTC
Tahnil wrote:
How did you manage this? Because I seem to have the same problem.



This type of error sounds very much like you've installed other Mods after TEA ...if you look in your apache/what ever webserver you use logs you will probably see a php fatal error ... this should tell you roughly where the problem is.
Zenith Gravit
LionGate Enterprises
#235 - 2014-03-21 02:47:22 UTC
Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "

Any suggestions?
Shin Chogan
Federal Navy Academy
Gallente Federation
#236 - 2014-03-21 19:18:24 UTC
Zenith Gravit wrote:
Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "

Any suggestions?



Sounds like you've done an uninstall at some point and then an install of a new version but the uninstall didn't complete correctly. This usually happens when you install other mods after TEA and the uninstall script can't find the bits it needs to remove from an existing file ... you are going to need to clean up your install I'm afraid.
Jen Moriarty
Out of Focus
Odin's Call
#237 - 2014-03-21 21:01:38 UTC
Hi there,

So I'm seeing a problem similar to the one described here: https://forums.eveonline.com/default.aspx?g=posts&m=3969052#post3969052

where accessing the userservice through a URL does add users to Openfire but the TEA section in SMF does not. Did you ever figure out what caused this?
Zenith Gravit
LionGate Enterprises
#238 - 2014-03-21 21:39:16 UTC
Shin Chogan wrote:
Zenith Gravit wrote:
Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "

Any suggestions?



Sounds like you've done an uninstall at some point and then an install of a new version but the uninstall didn't complete correctly. This usually happens when you install other mods after TEA and the uninstall script can't find the bits it needs to remove from an existing file ... you are going to need to clean up your install I'm afraid.



Damn...

Can you suggest an efficient way of doing this? I'm not really even sure of all the files that get edited.
lasterax
Republic Military School
Minmatar Republic
#239 - 2014-03-21 23:20:56 UTC  |  Edited by: lasterax
Migrated my forum to get on the same server as comms. Thins have gone well except for when running the API check, I get the following error:

Quote:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
File: /var/www/forums/Sources/TEA.php
Line: 2492


Checking the error log I also get the following:

8: Undefined property: TEA::$lastid


Something I missed doing the move?

--Rax
Zenith Gravit
LionGate Enterprises
#240 - 2014-03-22 13:17:12 UTC
I got my dirty install mostly cleaned up, but the user's profile page still has some extra fields and I'm just not sure what needs to be removed to clean it up. The Status, Main Matched Rules, Characters, ID from API page, and Verification Code from API Page fields are all duplicated once. I'm just trying to figure out how to clean that up.

Screen shot ----> http://i.imgur.com/0nHoabh.png