These forums have been archived and are now read-only.

The new forums are live and can be found at https://forums.eveonline.com/

EVE Technology Lab

 
  • Topic is locked indefinitely.
 

TEA (v1.3.1) - Member Management Mod for SMF 2, TeamSpeak 3 and Jabber

Author
Szczurek
BSX Industries
PanSwarm Federation Please Ignore
#201 - 2014-03-14 17:59:09 UTC
Hi Shin,

First, thanks a million for picking up this project :) Big kudos :)

Secondly, what's the best way to upgrade from 1.3.0 r179?
The 1.3.1 r5 package info do not carry the upgrade path.
Is the one from 1.3.0 applicable or does it need to be customized?

The one which was included in r179 looks like this (had to sanitize xml tags into || and |- respectively)
Quote:
||upgrade from="1.3.0 r155"|-
||readme type="file"|-readme.txt||/readme|-
||require-file name="TEA.php" destination="$sourcedir" |-||/require|-
||require-file name="TEAC.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_TS.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Jabber.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Jabber_OF.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_SkillDump.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Roles.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA.english.php" destination="$languagedir" |-||/require|-
||require-dir name="TEA" destination="$boarddir" |-||/require|-
||require-dir name="TS3_Class" destination="$sourcedir" |-||/require|-
||code|-tables.php||/code|-
||/upgrade|-
Shin Chogan
Federal Navy Academy
Gallente Federation
#202 - 2014-03-14 19:55:08 UTC
Szczurek wrote:
Hi Shin,

First, thanks a million for picking up this project :) Big kudos :)

Secondly, what's the best way to upgrade from 1.3.0 r179?
The 1.3.1 r5 package info do not carry the upgrade path.
Is the one from 1.3.0 applicable or does it need to be customized?

The one which was included in r179 looks like this (had to sanitize xml tags into || and |- respectively)
Quote:
||upgrade from="1.3.0 r155"|-
||readme type="file"|-readme.txt||/readme|-
||require-file name="TEA.php" destination="$sourcedir" |-||/require|-
||require-file name="TEAC.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_TS.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Jabber.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Jabber_OF.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_SkillDump.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA_Roles.php" destination="$sourcedir" |-||/require|-
||require-file name="TEA.english.php" destination="$languagedir" |-||/require|-
||require-dir name="TEA" destination="$boarddir" |-||/require|-
||require-dir name="TS3_Class" destination="$sourcedir" |-||/require|-
||code|-tables.php||/code|-
||/upgrade|-


Yeah ... I just uninstall and then reinstall. The database is not touched so you shouldn't loose anything.
Liez Onerbak
Norse'Storm Battle Group
#203 - 2014-03-15 02:53:05 UTC  |  Edited by: Liez Onerbak
I'm experiencing some issues as of today. If a user tries to register, or an existing user tries to update/add API to profile, or the cron runs (whichever happens first), the characters are coming back without corp tags and therefore not qualifying for any groups. Users are being removed from their groups as well....

For instance, The users are listed in the back end like: [] Your_Name (closed brackets where the corp tag would be)

Any ideas?

* Edit: Been working fine for months and nothing has changed/been updated recently. The only thing that's changed is the new eve patch but I can't imagine that would have anything to do with it...

* Edit #2: Confirmed the same problem happening on another site. Exact same issue.
Shin Chogan
Federal Navy Academy
Gallente Federation
#204 - 2014-03-15 09:07:57 UTC
Liez Onerbak wrote:
I'm experiencing some issues as of today. If a user tries to register, or an existing user tries to update/add API to profile, or the cron runs (whichever happens first), the characters are coming back without corp tags and therefore not qualifying for any groups. Users are being removed from their groups as well....

For instance, The users are listed in the back end like: [] Your_Name (closed brackets where the corp tag would be)

Any ideas?

* Edit: Been working fine for months and nothing has changed/been updated recently. The only thing that's changed is the new eve patch but I can't imagine that would have anything to do with it...

* Edit #2: Confirmed the same problem happening on another site. Exact same issue.



That sounds like the corp sheet XML is either corrupted or not being fetched. It might be worth looking in your tea api cache table for the last fetch of the corp in questions corpsheet and verifying it and probably removing it before refreshing the api of the accounts.
Dark Angel66
ANGELGARD.
The Initiative.
#205 - 2014-03-15 10:14:09 UTC
Hi friends, after patch my temark is crash down, he cant fetch char list.

registration -> input keyID -> input vCode -> push "get Characters" = error()

if update forum profile we can see first string "http://clip2net.com/s/716ADm"

please help for fix it.
Tahnil
Gunboat Commando
#206 - 2014-03-15 10:53:49 UTC  |  Edited by: Tahnil
Same problem over here! I think CCP changed the API, and Temars API Mod can‘t handle it.

Liez Onerbak wrote:
I'm experiencing some issues as of today. If a user tries to register, or an existing user tries to update/add API to profile, or the cron runs (whichever happens first), the characters are coming back without corp tags and therefore not qualifying for any groups. Users are being removed from their groups as well....

For instance, The users are listed in the back end like: [] Your_Name (closed brackets where the corp tag would be)

Any ideas?

* Edit: Been working fine for months and nothing has changed/been updated recently. The only thing that's changed is the new eve patch but I can't imagine that would have anything to do with it...

* Edit #2: Confirmed the same problem happening on another site. Exact same issue.
Shin Chogan
Federal Navy Academy
Gallente Federation
#207 - 2014-03-15 12:27:06 UTC  |  Edited by: Shin Chogan
Well if it only started happening Today then it can't be the patch as that was before that :)

What version are you guys running ?

The XML from CCP's servers looks just the same as it did before and while I hate to say it ... it works fine for me :) - I've just tried registering a new user and that is fine too.

Can you guys clear out your tea api cache table and also run the db_clean_up script to remove any orphaned api's/toons then retry things.

Dark Angel66 ... where is that screenshot taken ... I can't see enough of the page ... I think it is just the profile page of a user ... in which case just how is there 4 toons listed for a single api ? This is why I'm suggesting the db_clean_up script.
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#208 - 2014-03-15 12:50:22 UTC  |  Edited by: Demitrios
Well i did just type a nice long post on what CCP did to break the API checks, but it didn't allow html, so here's the post on my corps forums i posted.

http://di-tron.net/index.php?topic=1945

It has nothing to do with TEA though.
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#209 - 2014-03-15 13:04:15 UTC  |  Edited by: Demitrios
This is the problem that forum's that use TEA and anything else that uses its process are affected by.

With TEA, the software goes to /account/Characters.xml.aspx to get all the info it needs, including corporationID, but CCP have recently changed that page so it removes some of the columns, but not the data those columns have.

So when you pull the xml, you get this...

Quote:
rowset name="characters" key="characterID" columns="name,characterID,corporationName,corporationID"

row name="Demitrios" characterID="149537332" corporationName="Di-Tron Heavy Industries" corporationID="732773091" allianceID="1220174199" allianceName="Fatal Ascension" factionID="0" factionName=""/


See what happened there?

The columns ended at corporationID, but the data for allianceID, allianceName, factionID and factionName is still there.

So now what happens, is TEA and other apps goto pull /corp/CorporationSheet.xml.aspx, which includes the data "corporationID=732773091" allianceID="1220174199" allianceName="Fatal Ascension" factionID="0" factionName=" ", causing the api server to have a hissy fit.

Getting the code to ignore everything after corporationID is easy, but will likely break if/when CCP fix it.
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#210 - 2014-03-15 13:28:42 UTC
Been speaking with someone on twitter, who i assume is from CCP, no idea's as I generally avoid twitter like the plague, but hopefully it will be fixed soon.

https://twitter.com/DTHI_Demitrios/status/444808197376057344
Tahnil
Gunboat Commando
#211 - 2014-03-15 13:58:42 UTC
Shin Chogan wrote:
Well if it only started happening Today then it can't be the patch as that was before that :)

What version are you guys running ?


I‘m running v1.3.1r4

If there were no registrations and API checks since patch day, I think it still is possible. I think Demitrios may have identified the issue. Doesn‘t explain though why it works in some versions of the mod, while it‘s broken in others.
Imperium Romanus
Yamagata Syndicate
Northern Coalition.
#212 - 2014-03-15 14:09:09 UTC
Maybe it is affecting TEA auth only looking @ corpID. Alliance forums using TEA seem fine.
Oreamnos Amric
Confidently Incompetent
#213 - 2014-03-15 14:20:19 UTC
I'm running an older version of TEA and made the following change to fix the issue with the changed attributes

In file 'Sources/TEAC.php' I changed line 573 and 1006 from

$char = explode('" />', $char[1], 2);

to

$char = explode('" allianceID="', $char[1], 2);

This seems to have fixed the problem for now but the real fix would be to properly process XML as XML rather than rely on the ordering of CCP's API output.

I haven't looked at the updated version of the code by the OP of this thread. I assume it has the same problem from the comments above this.
Dark Angel66
ANGELGARD.
The Initiative.
#214 - 2014-03-15 15:06:38 UTC
Oreamnos Amric wrote:
I'm running an older version of TEA and made the following change to fix the issue with the changed attributes

In file 'Sources/TEAC.php' I changed line 573 and 1006 from

$char = explode('" />', $char[1], 2);

to

$char = explode('" allianceID="', $char[1], 2);

This seems to have fixed the problem for now but the real fix would be to properly process XML as XML rather than rely on the ordering of CCP's API output.

I haven't looked at the updated version of the code by the OP of this thread. I assume it has the same problem from the comments above this.


thx!
Shin Chogan
Federal Navy Academy
Gallente Federation
#215 - 2014-03-15 15:08:28 UTC  |  Edited by: Shin Chogan
Ah Ha ... nice find Demitrios. I looked too late in the process sequence ... I was rushing to take a look before heading to the Opticians and didn't track back far enough.

I suppose you could add in some code to truncate after the first space and use that for corpID but as you say we shouldn't have to coz it is just broken xml.



Oreamnos Amric - the new versions do exactly what you say ... they put the returned XML in a SimpleXML object and use that for the parsing ... much nicer than the older way of doing it but it means that if the XML is invalid there are problems which is exactly what we are seeing here.
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#216 - 2014-03-15 15:25:12 UTC
I just looked at the cache, showed me what commands were being sent to the api, just needed to figure out where it was getting that extra info to send.

The dev said that he added extra into to the api result, but looking at http://wiki.eve-id.net/APIv2_Account_Characters_XML seems to suggest that information was there previously.

In any case, with or without the extra info, it would work fine if the extra data had columns put in.

At least it will be fixed in the next few days, and the change to the test api server shows the fix in action.

http://api.testeveonline.com/account/Characters.xml.aspx?keyID=1467486&vCode=vICLFqVcIdY596Q83sFPoYvAsWGWzl6oEnXs1AVorAsX8BqMW4pkxAfu4JQmVjmE
Oreamnos Amric
Confidently Incompetent
#217 - 2014-03-15 15:26:37 UTC
Shin Chogan wrote:
Oreamnos Amric - the new versions do exactly what you say ... they put the returned XML in a SimpleXML object and use that for the parsing ... much nicer than the older way of doing it but it means that if the XML is invalid there are problems which is exactly what we are seeing here.


Treating XML as XML you say? Well I'm sold Big smile

There isn't a massive amount you can do with malformed XML except behave properly. I'd seen the old TEA remove everyone's access when the API didn't return any information at all. Probably due to the same code as was hit here. With a proper XML parser you at least know if you have received junk data and can behave properly (i.e. do nothing rather than mess up everyone's access).
Shin Chogan
Federal Navy Academy
Gallente Federation
#218 - 2014-03-15 15:41:44 UTC  |  Edited by: Shin Chogan
Hmmmmm .... "interesting"

row characterID="xxxxx" characterName="xxxxxxx" corporationID="1000168" corporationName="Federal Navy Academy"

pulled from my tea cache from a cron fetch done at :

currentTime 2014-03-15 15:17:16 /currentTime


looks like they've gone the other way on Tranquility's api server.
Liez Onerbak
Norse'Storm Battle Group
#219 - 2014-03-15 17:51:42 UTC
I'm assuming we just basically need to wait for CCP to fix this? If we change things now it's just going to break again when they change/fix things on their end, right?
Demitrios
Di-Tron Heavy Industries
OnlyFleets.
#220 - 2014-03-15 18:24:00 UTC
I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it.