EVE Technology Lab

I'm trying to check an api for a character id using PHP.

This is the code I'm using

http://pastebin.com/VYbNVtgY (even in code tags this **** forum yells at me for posting code)

Obviously $id is defined earlier, but for some reason this isn't working?


Basically just need to make sure the character id exists somewhere in the xml

Bah... literally wasted 2 hours on this and going from = to == fixed it haha. Thanks!

Ya still getting into the good habits, self taught myself php while deployed over the winter so my code isn't the cleanest.

Add a new column to your characters table named 'UpdatedAt'(or something like that) of type "DateTime".
Change

$query = 'SELECT charid FROM services.members;';

To

$query = 'SELECT charid FROM services.members ORDER BY UpdatedAt DESC;';

(You can even consider adding a LIMIT here)

Then wrap your other stuff in a loop

// Corp Check

while( $row = mysqli_fetch_row($result) ) {
 
                                        $url = 'https://api.eveonline.com/eve/CharacterInfo.xml.aspx';
                                        $url .= '?characterID=' . urlencode($result);
                                       
                                        $xml = makeApiRequest($url);
                                        $corpid = (int) $xml->result->corporationID;
                                       
                                        if ($corpid == '875512489') { $query2 = 'UPDATE services.members SET role = "MAMBA" WHERE charid = $result LIMIT 1'; }
                                        else { $query2 = 'UPDATE services.members SET role = "OOC" WHERE charid = $row[0] LIMIT 1'; }
 
                                        $result2 = mysqli_query($con,$query2);
 
  if (!$result2) {
    die('Invalid query: ' . mysql_error());
}

}

Havent tested this code, might be some syntax issues, but you get the idea.

I really recommend you to read about PDO and use that instead of mysqli bs.
Also, have a look at https://github.com/3rdpartyeve/phealng - this lib handles all the boring stuff and is pretty easy to use.


P.S. This reminds me i need to speed up the release of my Starlight project.

If you want php to interpret variables inside strings you need to use double quotes " not single quotes '.

so either

$query2 = "UPDATE services.members SET role = \'OOC\' WHERE charid = $row[0] LIMIT 1";

or

$query2 = 'UPDATE services.members SET role = \'OOC\' WHERE charid = '.$row[0].' LIMIT 1';

would be cool if there was an php dev channel to discuss issues like this so that when the guy wastes 2 hours over a syntax error he doesnt have to wait even longer for a forum post.

#eve-dev on coldfront is dead.

Something I would suggest to anyone especially learning a new programming language is to find a good editor with syntax highlighting it'll make a big difference in finding errors like these. Even better is a good IDE which can include plug-ins for code inspections which can catch even more things and help enforce good coding practices. For a simple code editer I like Notepad++(Windows) but an IDE is much better and a couple I've used are Komodo-edit (free, cross-platform) and the one I current use which is PhpStorm (free trail, cross-platform) from JetBrain. It's code style settings and inspections are very good. It also understands more than just PHP and will help with the SQL syntax etc as well. For some coding standards for PHP you should look at the PSR ones. PHPStorm even let's you set it up to correct the formatting for you on commits etc.

Also as someone pointed out except if you are just doing for the learning it's better not to be re-inventing the wheel when it comes to the Eve API. The are existing libraries like Pheal-ng or my own Yapeal which deal with all the misc cruft and inconsistent there are in the APIs so you don't have to. Even if your just trying to learn you would probably find looking at other people's code useful especially where we're solving the same problems you are trying to work on.